-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Built in alt inst unlocking #3961
base: develop
Are you sure you want to change the base?
Conversation
Btw that also fixes a problem where a song with a Pico Mix couldn't have an other altInst using the _merge folder |
i made something like this on FunkinCrew/funkin.assets#105 |
Yeah, but you have to manually put it every times, here it's built in, with just the need of a check box in the chart editor |
o ok |
This PR appears to have merge conflicts. Please fix them! |
wait there is the assets to update before (and for some reasons, I can't manage to do it) |
Looks like this PR needs a rebase. |
98884b4
to
6216655
Compare
FYI This PR needs to be based on the |
well, I can't draft it anymore, trying to update the assets |
c392b65
to
d8b8c66
Compare
I CAN'T REMEMBER HOW TO CHANGE THE SUBMODULE FROM THE MAIN REPO!!! |
5bfc7dd
to
d8b8c66
Compare
I REMEMBERED!!! |
This add a built in check of available alt inst and if it's unlocked, allowing to remove that annoying function found in almost all song scripts (and will be easier do add more mixes)
It also adds the
unlockedInstByDefault
property in the song metadata of a song alt to lock it (since it's unlocked by default if the property doesn't exits)