[ENHANCEMENT] Better mod support for stickers (StickerRegistry) #4003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr: haxe
This was referenced Jan 15, 2025
|
Oh, this is nice! Good work! |
|
I like how this standardizes the stickers to match how the rest of the game uses data. However, this PR has merge conflicts with v0.6 (it utilizes the previously unused sticker pack system). We can resolve those at that point. |
EliteMasterEric
added
status: planned
EliteMasterEric
added
status: planned
AbnormalPoof
force-pushed
the
feat/modded-sticker-packs
branch
from
efaf7c8 to
2f73439
Compare
|
Oops I fucked up the rebase hold on |
AbnormalPoof
force-pushed
the
feat/modded-sticker-packs
branch
2 times, most recently
from
f4855fa to
3e19d29
Compare
|
Everything is one neat commit now thank god |
AbnormalPoof
added
the
pr: documentation
|
Marking this PR as a draft until v0.6.0 comes out so I can update it accordingly. |
AbnormalPoof
force-pushed
the
feat/modded-sticker-packs
branch
from
3e19d29 to
29e8c27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Implements #3969
Briefly describe the issue(s) fixed.
This PR moves sticker sets to its own registry called
StickerRegistry, and replaces the old(and quite frankly crude)StickerInfoclass with a new class calledStickerSet. This should hopefully streamline the process of making custom sticker sets, since mods no longer need to directly replacestickers-set-1or use JSON patching.Notes
data/stickersets(andStickerInfobeing removed). But that's up to Eric to decide.stickers-set-1: Movestickers-set-1todata/stickersets/funkin.assets#109StickerSpritenow takes a file path instead of sticker set and sticker names to support custom file paths for sticker sets.