Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update art submodule commit version #4100

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Lasercar
Copy link
Contributor

@Lasercar Lasercar commented Feb 4, 2025

Does this PR close any issues? If so, link them below.

Briefly describe the issue(s) fixed.

I've had to avoid accidentally including the new commit version of the art assets in my commits, so here's a PR to just update it on it's own.

I'm a little surprised that no one noticed or has fixed this already.

Ah yes, github bot, yes, this is definitely a 'small' commit (it totally doesn't add 100 new files). /s

Include any relevant screenshots or videos.

@github-actions github-actions bot added status: pending triage Awaiting review. size: small A small pull request with 10 or fewer changes. labels Feb 4, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Feb 4, 2025

Can you elaborate on what this PR solves? I didn't quite understand your explanation, and we generally don't merge PRs modifying submodules.

@Hundrec Hundrec added status: needs clarification Requires more info from the author. and removed status: pending triage Awaiting review. labels Feb 4, 2025
@Lasercar
Copy link
Contributor Author

Lasercar commented Feb 4, 2025

This PR fixes this:
Screenshot 2025-02-04 201009

If I click 'stage changed' it includes the updated art submodule and I have to unstage it or else accidentally have it included in one of my commits.

Hence, this PR to just update it.
You could probably ask @EliteMasterEric to update it though (but then again, I did notice this first...).

@Hundrec Hundrec added the type: chore Involves minor adjustments that do not make functional changes. label Feb 4, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented Feb 4, 2025

Okay, I'll ask Eric about this and get back to you

@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: needs clarification Requires more info from the author. labels Feb 4, 2025
@EliteMasterEric EliteMasterEric merged commit ca16d41 into FunkinCrew:main Feb 4, 2025
8 checks passed
@Lasercar
Copy link
Contributor Author

Lasercar commented Feb 4, 2025

I did not expect this to be my first merged contribution

@Lasercar
Copy link
Contributor Author

Lasercar commented Feb 4, 2025

Oh, also, you might want to consider doing this for the develop branch as well. This is done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: chore Involves minor adjustments that do not make functional changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants