Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pico death spritesheet #1

Closed
wants to merge 5 commits into from
Closed

Fix Pico death spritesheet #1

wants to merge 5 commits into from

Conversation

doggogit
Copy link
Contributor

@doggogit doggogit commented May 8, 2024 •
edited
Loading

With Free Texture Packer, there is a built-in PNG optimizer, called tinyPNG.

When a spritesheet is too large and is ran through tinyPNG, it'll overcompensate and transparency will be lost, leading to a tint appearing across the entire sprite.

I re-exported the sheet using Funkin Packer (a fork of Free Texture Packer by Ne_eo), but this time, running it through only oxipng.

Even at oxipng's highest optimization flag level, no tint appears.

@usb-port-2
Copy link

Funkin Packer my beloved

@EliteMasterEric EliteMasterEric added type: minor bug Involves a minor bug or issue. status: reviewing internally Cannot be approved; under continuing review and quality assurance testing labels Jun 16, 2024
@EliteMasterEric EliteMasterEric self-assigned this Jun 16, 2024
@EliteMasterEric EliteMasterEric added the polish PR involves minor polish to the UI or gameplay. label Jun 16, 2024
@EliteMasterEric EliteMasterEric added status: pending triage The bug or PR has not been reviewed yet. status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. size: small A small pull request with 10 or fewer changes type: minor bug Involves a minor bug or issue. and removed type: minor bug Involves a minor bug or issue. status: reviewing internally Cannot be approved; under continuing review and quality assurance testing polish PR involves minor polish to the UI or gameplay. status: pending triage The bug or PR has not been reviewed yet. labels Jul 9, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.0 milestone Jul 13, 2024
@doggogit doggogit closed this by deleting the head repository Jul 13, 2024
@doggogit
Copy link
Contributor Author

Oh my God, I'm so stupid..

I accidentally deleted the fork by accident, Jesus Christ.

@EliteMasterEric has this been merged internally or do I need to re-open?

@doggogit doggogit mentioned this pull request Jul 14, 2024
Closed
@doggogit
Copy link
Contributor Author

Reopened in #50. God.

@EliteMasterEric EliteMasterEric added status: resolved status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue. and removed type: minor bug Involves a minor bug or issue. status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. size: small A small pull request with 10 or fewer changes status: resolved labels Jul 25, 2024
@EliteMasterEric EliteMasterEric added the size: small A small pull request with 10 or fewer changes label Jul 25, 2024
@EliteMasterEric
Copy link
Member

Oh yeah this got merged internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: small A small pull request with 10 or fewer changes status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@doggogit @usb-port-2 @EliteMasterEric