[Chart Enhancement] Fix Eggnog Erect ending notes + small adjustments

[afreetoplaynoob]

The ending of Eggnog Erect was using the wrong BPM (80, instead of 70, half of the song's main speed) and the four ending notes were off-sync, so I fixed those things and made some other changes to the chart.

Fixes this in both Erect and Nightmare difficulties.

[afreetoplaynoob]

I thought I had already gotten rid of the Hard difficulty but when tweaking the files again I forgot to get rid of it again. Also wasn't aware of the charter being removed. Thank you for pointing it out!

[Hundrec]

No problem!
I've been curious: What is the full list of changes you made to the chart?
Ideally, we would be able to go in and manually edit the notes and events without re-exporting the song and making comparison difficult. (See line changes for #96 as an example)

[afreetoplaynoob]

Excluding the aformentioned BPM change and ending notes:

Section 11 - Parents (Christmas)

Added a 32nd down note to accurately chart the grace.

Section 15 - Parents (Christmas)

Added a 32nd right note to accurately chart the grace.

Section 47 - Parents (Christmas)

Added an up note for the small note Daddy Dearest sings here.

Section 56 - Boyfriend (Christmas)

Removed the down note grace here and moved the right note a bit earlier.

Section 30 - Boyfriend (Christmas) [ERECT Exclusive]

Moved the three notes immediately after the event a bit lower to sync with the singing.

Note

The section 56 change isn't in the PR itself yet, as I only figured out the proper timing for the note when gathering screenshots for this comment.

[Hundrec]

Thanks for the changelog!
However, your screenshots (and your note changes) were affected by FunkinCrew/Funkin#3580, which can be fixed by re-selecting Eggnog after switching to Nightmare difficulty.
Another tip is to select the notes you made changes to for easy readability!

[afreetoplaynoob]

Yes, I noticed I forgot to highlight the notes after I posted my comment. Hopefully I've managed to still describe what and where the chart changes were supposed to be regardless.
And thank you for the switching difficulty tip! It was... inconvenient to playtest with this bug, to say the least; will try it later!

[Hundrec]

Yeah, the grid is super important!
I'll clarify that it looks like the new notes you've placed align in 32nds with the regular variation's 150bpm grid, affecting the accuracy of the placements. Please revise these placements on the correct grid and update me with the changes!

[afreetoplaynoob]

Alright, here's the changes again, now in their proper positions and sections, with the changed notes highlighted and already manually edited into the original file:

Section 10 - Parents

Section 14 - Parents

Section 44 - Parents

Section 52 - Boyfriend

Section 71 - Both

Here's how it looks like in 70 BPM:

And how it looks like in 140 BPM, for easier viewing:

Section 28 - Boyfriend [ERECT Only]

[Hundrec]

Thanks so much! I'll look into these changes when I have the time and create a branch in my fork that manually edits the json files without re-exporting the chart.

That way we can use the GitHub diffs for comparison and save some disk space for the game!

[Hundrec]

Oh whoops, didn't notice you had noted that you already made those manual edits.
Can you commit those changes to this PR so I can examine them?

[Hundrec]

Also just noticed that you already made a commit for those manual edits.
I wonder why GitHub is displaying the diffs as if they're replacing entire chunks instead of just the parts you changed...

[afreetoplaynoob]

Pretty sure it's from all the changes and addendums we've made to the file; this PR started with an exported chart file and then went back to the original file format, so it's seeing it as the diffs to the exported format.

[Hundrec]

Got it, then I will manually copy over your files to my fork and see if the diffs are small there

[Hundrec]

Just checked out your changes and they're great!
If you can squash this PR into one commit, it should look like this branch and be easily comparable.

One minor detail is that I would keep the "generatedBy" in both files 0.3.2, rather than 0.5.3 since this is now a manual edit.

[afreetoplaynoob]

Looks like I miscalculated there, the diffs are still messed up... I either squashed wrong or that's just how it was going to end up anyway, seeing as it was still 8 commits that probably collectively messed up the format/diffs.
At this point we're better off if l delete the repo and close this PR so I can make a new one with good diffs.