weekend1 rain in later songs now starts on stage start fix

[Lasercar]

Does this PR close any issues? If so, link them below.

FunkinCrew/Funkin#4078
Already fixed by this #9 PR

Briefly describe the issue(s) fixed.

In the other 2 songs of weekend 1, the rain doesn't start until the song starts. This fix provides passes the rainShaderStartIntensity for the rain's remappedIntensityValue instead of the songPosition if the it's less than zero.

Include any relevant screenshots or videos.

I noticed that AppleHair made a fix for that put the remappedIntensityValue update in a null check, so I've also done the same thing so that it's easier to merge? Idk if that's how it works.
If I need to make the change from a branch that starts with the community fixes let me know and I'll quickly fix this PR.

[Lasercar]

Hmm, I wonder if there's anything else I can fix/do...

[AppleHair]

It's cool that you managed to figure out the solution on your own, but I made #9 8 months ago, and it does exactly the same thing. It was also already merged to the community fixes branch a while ago, so I don't see how this PR is necessary.

[Lasercar]

Hm? Your change fixes the story mode start, where the rain is at max strength until the first song starts.
This fixes the rain not appearing in the later songs before the song starts, though I can understand the confusion.

Oh, I see the problem, I wasn't clear enough with what it was I fixing.

[Hundrec]

@AppleHair Can you confirm that your PR resolves all issues with the rain, including the one linked from this PR?

[AppleHair]

Hm? Your change fixes the story mode start, where the rain is at max strength until the first song starts.
This fixes the rain not appearing in the later songs before the song starts, though I can understand the confusion.

Look at what #9 changes in the code and tell me how it's different from this PR

[Lasercar]

AppleHair's PR:
remappedIntensityValue = FlxMath.remapToRange(Conductor.instance.songPosition, 0, FlxG.sound.music.length, rainShaderStartIntensity, rainShaderEndIntensity);
to my PR:
remappedIntensityValue = FlxMath.remapToRange(Conductor.instance.songPosition > 0 ? Conductor.instance.songPosition : rainShaderStartIntensity, 0, FlxG.sound.music.length, rainShaderStartIntensity, rainShaderEndIntensity);

[Hundrec]

I took a glance on mobile, but couldn't verify whether the code was the same (or had the same effect) since I'm not a coder.
I only need confirmation that your solution resolves Funkin' issue #4078 before I mark this as a duplicate.

[Lasercar]

Ah, ok I get it now.
So, AppleHair's change makes so that the the rain doesn't start until the song starts.
However, that introduces the issue I noticed, where the rain is absent until the song starts.

[Hundrec]

Are you sure? The video in your bug report should have been on an unmodified build of 0.5.3, right?
AppleHair's change is coming to 0.6.0

[AppleHair]

AppleHair's PR: remappedIntensityValue = FlxMath.remapToRange(Conductor.instance.songPosition, 0, FlxG.sound.music.length, rainShaderStartIntensity, rainShaderEndIntensity); to my PR: remappedIntensityValue = FlxMath.remapToRange(Conductor.instance.songPosition > 0 ? Conductor.instance.songPosition : rainShaderStartIntensity, 0, FlxG.sound.music.length, rainShaderStartIntensity, rainShaderEndIntensity);

Conductor.instance.songPosition > 0 will always be true when FlxG.sound.music != null (because the song is playing), so Conductor.instance.songPosition > 0 ? Conductor.instance.songPosition : rainShaderStartIntensity will always result in Conductor.instance.songPosition, because it only runs when FlxG.sound.music != null, so this doesn't make any difference.

[Lasercar]

Ah, so you fixed it by doing this,
var remappedIntensityValue:Float = rainShaderStartIntensity;
and putting the remap into a check if the song's playing

where as I did this: Conductor.instance.songPosition > 0 ? Conductor.instance.songPosition : rainShaderStartIntensity

And by making/adding your change, I basically made my change redundant, even though they fix the same thing.

Now I get it.

Whoops.

[Hundrec]

Thanks for the clarification. I'm going to close this PR as a duplicate as it is redundant to AppleHair's solution.