Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Roses Cutscene #24

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Fix Roses Cutscene #24

merged 4 commits into from
Oct 16, 2024

Conversation

RubixDroid
Copy link

Did this a little while ago but forgot to make a PR

Corrects the sound effect and removes the bg music for the Roses cutscene

@EliteMasterEric EliteMasterEric added status: reviewing internally Cannot be approved; under continuing review and quality assurance testing polish PR involves minor polish to the UI or gameplay. labels Jun 16, 2024
@EliteMasterEric EliteMasterEric added status: pending triage The bug or PR has not been reviewed yet. and removed polish PR involves minor polish to the UI or gameplay. status: reviewing internally Cannot be approved; under continuing review and quality assurance testing labels Jul 9, 2024
@Hundrec
Copy link
Collaborator

Hundrec commented Oct 4, 2024

A small change that does a lot for Week 6's immersion!
In 0.5.1, Lunchbox still plays while Senpai is angry and it's an odd sight.

@EliteMasterEric EliteMasterEric added type: minor bug Involves a minor bug or issue. status: reviewing internally Cannot be approved; under continuing review and quality assurance testing and removed status: pending triage The bug or PR has not been reviewed yet. labels Oct 16, 2024
@EliteMasterEric
Copy link
Member

Had to make a fix for setting music.asset ="" but this is good otherwise

@EliteMasterEric EliteMasterEric changed the base branch from main to feature/emcf October 16, 2024 18:29
@EliteMasterEric EliteMasterEric merged commit d2d3732 into FunkinCrew:feature/emcf Oct 16, 2024
@EliteMasterEric EliteMasterEric added status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Cannot be approved; under continuing review and quality assurance testing labels Oct 16, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.3 milestone Oct 16, 2024
@Hundrec Hundrec added the size: medium A medium pull request with 100 or fewer changes label Jan 23, 2025
@AbnormalPoof AbnormalPoof mentioned this pull request Jan 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: medium A medium pull request with 100 or fewer changes status: accepted Approved for contribution. If it's not already merged, it may be merged on a private branch. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
0.5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@RubixDroid @Hundrec @EliteMasterEric