Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fetch-depth to actions/checkout to fix CI #120

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

jamesbraza
Copy link
Collaborator

From this CI run, we get:

  × No solution found when resolving dependencies for split
  │ (python_full_version == '3.11.*' and platform_python_implementation ==
  │ 'PyPy'):
  ╰─▶ Because only the following versions of paper-qa are available:
          paper-qa<=5.0.0
          paper-qa==5.0.1
...
          paper-qa==5.3.2
      and paper-qa==5.3.2 depends on fhaviary, we can conclude that
      paper-qa>5.3.1 depends on fhaviary.
      And because paper-qa>=5.0.0,<=5.3.1 depends on fhaviary, we can conclude
      that paper-qa>=5.0.0 depends on fhaviary.
      And because fhaviary[paperqa] depends on paper-qa>=5 and your workspace
      requires fhaviary[paperqa], we can conclude that your workspace's
      requirements are unsatisfiable.

      hint: The package `paper-qa` depends on the package `fhaviary` but the
      name is shadowed by one of your workspace members. Consider changing the
      name of the workspace member.

This is related to our "circular" pinning with paper-qa (where paper-qa depends on fhaviary, and we have a convenience paperqa extra here). Note that paper-qa currently pins ``fhaviary[llm]>=0.8.2`.

#117 tried to fix this by downpinning uv<0.5, but that didn't work. So this PR looks closer, and realizes in this CI run's logs for uv sync --verbose:

Installed 124 packages in 121ms
...
 + fhaviary==0.1.dev1+g6ddf4a0 (from file:///home/runner/work/aviary/aviary)

This is incorrect! So this leads me to pypa/setuptools-scm#952, where I realized we ned to add fetch-depth: 0 so the correct version of fhaviary gets used in CI.

Someday after actions/checkout#1471 we can just use fetch-tags: true.

@jamesbraza jamesbraza added the bug Something isn't working label Nov 8, 2024
@jamesbraza jamesbraza self-assigned this Nov 8, 2024
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 8, 2024
Copy link
Contributor

@whitead whitead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scooby doo level mystery

@jamesbraza jamesbraza merged commit 6a31773 into main Nov 8, 2024
5 checks passed
@jamesbraza jamesbraza deleted the adding-fetch-depth branch November 8, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants