Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Remove unnecessary act statements #6513

Merged
merged 2 commits into from
May 4, 2023
Merged

Conversation

petertgiles
Copy link
Contributor

πŸ€– Resolves #6223

πŸ‘‹ Introduction

This branch solves Jest error messages in the SelfDeclarationForm.test.tsx file.

πŸ•΅οΈ Details

It seems like this error message happens when there are unnecessary act statements. It seems to also be related to React 18 so it probably these started at that point.
testing-library/react-testing-library#1061

πŸ§ͺ Testing

  1. In the apps/web directory run npx jest --testPathPattern=SelfDeclarationForm.test.tsx
  2. Observe that all tests pass and there are no console error messages.

πŸ“Έ Screenshot

image

@petertgiles petertgiles changed the title Remove unnecessary act statements [Bug] Remove unnecessary act statements May 4, 2023
Copy link
Contributor

@vd1992 vd1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

image

@petertgiles petertgiles merged commit 683929a into main May 4, 2023
@petertgiles petertgiles deleted the 6223-fix-jest-tests branch May 4, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest - SelfDeclarationForm tests not configured to support act
2 participants