Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made NavBar responsive #21

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Made NavBar responsive #21

wants to merge 11 commits into from

Conversation

mrshivamshaw
Copy link
Member

@mrshivamshaw mrshivamshaw commented Oct 28, 2023 •
edited
Loading

Related Issue

  • NavBat was not responsive
  • Issue number goes here:

Proposed Changes

  • Change 1 : Made responsive for mobile screens also
  • Change 2
  • Change 3

Checklist

  • Documentation of the code
  • Add your name to the CONTRIBUTORS file
  • Testing your code in the local machine

Screenshots

@netlify
Copy link

netlify bot commented Oct 28, 2023 •
edited
Loading

✅ Deploy Preview for gdscaec-react ready!

Name Link
🔨 Latest commit 972820a
🔍 Latest deploy log https://app.netlify.com/sites/gdscaec-react/deploys/653e63121695530008b3e70c
😎 Deploy Preview https://deploy-preview-21--gdscaec-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

paardarshee
paardarshee requested changes Oct 29, 2023
View reviewed changes
Copy link
Member

@paardarshee paardarshee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivamshaw07
We have no use of react-router-dom

also merge the latest main branch in you PR
will you please remove it update your packages and then update this PR

@mrshivamshaw mrshivamshaw reopened this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paardarshee paardarshee paardarshee requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrshivamshaw @paardarshee