Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer_section_improved #43

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

Alekhya-Dharam
Copy link
Contributor

This PR improved the footer section as mentioned in the figma design.

Related Issue

Checklist

  • Documentation of the code
  • Add your name to the CONTRIBUTORS file
  • Testing your code in the local machine

Screenshots

footer

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for gdscaec ready!

Name Link
🔨 Latest commit 61bf3ce
🔍 Latest deploy log https://app.netlify.com/sites/gdscaec/deploys/65263f69616277000822f76e
😎 Deploy Preview https://deploy-preview-43--gdscaec.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@paardarshee paardarshee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have implemented Quiet Impressive,

Could you update the designs little more?
To-d0's:

  • - Increase width of GDSC AEC (max-720px min-2/3vw)

  • - There is Extra Spacing below GDSC AEC

  • - Add this to the End (↓)

<!-- Copyright Information -->
            <p>&copy; 2023 GDSC Club Name. All rights reserved.</p>

For further Details you can connect us over Discord

@Alekhya-Dharam
Copy link
Contributor Author

You have implemented Quiet Impressive,

Could you update the designs little more? To-d0's:

  • - Increase width of GDSC AEC (max-720px min-2/3vw)
  • - There is Extra Spacing below GDSC AEC
  • - Add this to the End (↓)
<!-- Copyright Information -->
            <p>&copy; 2023 GDSC Club Name. All rights reserved.</p>

For further Details you can connect us over Discord

Sure 😊
All rights preserved statement should be in center or left aligned??

@paardarshee
Copy link
Member

You have implemented Quiet Impressive,

Could you update the designs little more? To-d0's:

  • - Increase width of GDSC AEC (max-720px min-2/3vw)
  • - There is Extra Spacing below GDSC AEC
  • - Add this to the End (↓)
<!-- Copyright Information -->
            <p>&copy; 2023 GDSC Club Name. All rights reserved.</p>

For further Details you can connect us over Discord

Sure 😊
All rights preserved statement should be in center or left aligned??

Center

@Alekhya-Dharam
Copy link
Contributor Author

You have implemented Quiet Impressive,
Could you update the designs little more? To-d0's:

  • - Increase width of GDSC AEC (max-720px min-2/3vw)
  • - There is Extra Spacing below GDSC AEC
  • - Add this to the End (↓)
<!-- Copyright Information -->
            <p>&copy; 2023 GDSC Club Name. All rights reserved.</p>

For further Details you can connect us over Discord

Sure 😊
All rights preserved statement should be in center or left aligned??

Center

Is this fine??

Screenshot
footer_new

@paardarshee
Copy link
Member

You have implemented Quiet Impressive,
Could you update the designs little more? To-d0's:

  • - Increase width of GDSC AEC (max-720px min-2/3vw)
  • - There is Extra Spacing below GDSC AEC
  • - Add this to the End (↓)
<!-- Copyright Information -->
            <p>&copy; 2023 GDSC Club Name. All rights reserved.</p>

For further Details you can connect us over Discord

Sure 😊
All rights preserved statement should be in center or left aligned??

Center

Is this fine??

Screenshot
footer_new

All looks good
Just make the above spacing of DSC equal to the bottom one.

@Alekhya-Dharam
Copy link
Contributor Author

I have made the necessary changes, committed them, and pushed them into the same PR.
So pls review it and give hacktoberfest label, I hope you will merge it with your code.

Copy link
Member

@paardarshee paardarshee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paardarshee paardarshee merged commit 7200fef into GDGCampusAEC:main Oct 11, 2023
4 checks passed
@paardarshee paardarshee linked an issue Oct 11, 2023 that may be closed by this pull request
@paardarshee paardarshee added the hacktoberfest-accepted Label for accepted PRs made during hacktoberfest label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Label for accepted PRs made during hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add an organisation footer
2 participants