Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a directory for the shaders before compilation #14

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

GoncaloFDS
Copy link
Contributor

The first time you compile the project on windows the build fails because the shader compilation output directory does not exist.
image

This line creates that directory.

@GPSnoopy
Copy link
Owner

GPSnoopy commented Aug 7, 2020

I'm curious why this works on my machine and the CI but not on yours? Something must be different.

Mind you, we already do explicitly create the directory on Linux, so this would just bring Windows on par. I need to clean this up at some point, the repo is a bit of a mess for the moment.

@GPSnoopy GPSnoopy merged commit 1a2469a into GPSnoopy:master Aug 7, 2020
@GoncaloFDS
Copy link
Contributor Author

I'm using clion, so that might have something to do with it. I'll try building with VS to see if the problem is related to the ide.

@GoncaloFDS GoncaloFDS deleted the create-cmake-shader-directory branch August 7, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants