fix paths that don't have light contributions #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
Paths that do not hit a light are giving a contribution and they shouldn't. e.g If a path it's a wall and terminates if contribution should be zero however with the current code we get that the contribution of that path is the color of the material.
Solution:
if the path exceeds the max path length and it didn't get a contribution from a light, that path contribution is zero.
Path length 1:
Path length 2:
Path length 3:
And some samples gathered from the Ray Tracing: The Rest of Your Life
Path length 1:
Path length 2:
Path length 3: