Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate swapchain on VK_SUBOPTIMAL_KHR #35

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

Flakebi
Copy link
Contributor

@Flakebi Flakebi commented Feb 18, 2021

vkQueuePresentKHR can return VK_SUBOPTIMAL_KHR if the window size
changed. This should recreate the swapchain, like for
VK_ERROR_OUT_OF_DATE_KHR.

@GPSnoopy
Copy link
Owner

Shouldn't the result of vkAcquireNextImageKHR also be checked for this then?

vkQueuePresentKHR can return VK_SUBOPTIMAL_KHR if the window size
changed. This should recreate the swapchain, like for
VK_ERROR_OUT_OF_DATE_KHR.
@GPSnoopy GPSnoopy merged commit 8e88678 into GPSnoopy:master Feb 18, 2021
@Flakebi
Copy link
Contributor Author

Flakebi commented Feb 18, 2021

Thanks, that was quick!

@Flakebi Flakebi deleted the suboptimal branch February 18, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants