Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from "npm ci" to "npm install" for CI #719

Merged
merged 3 commits into from
Nov 3, 2021
Merged

Switch from "npm ci" to "npm install" for CI #719

merged 3 commits into from
Nov 3, 2021

Commits on Nov 3, 2021

  1. Switch from "npm ci" to "npm install" for CI 

    **Why**: Because "npm ci" ignores and destroys the cached node_modules and is otherwise difficult to cache. "npm install" should behave similar, respect package-lock.json, hydrate from cache. The other behavior of "npm ci" of validating package-lock.json isn't always reliable, and is replicated here with check-lockfiles, largely copied from similar scripts in identity-style-guide and identity-idp.
    @aduth
    aduth committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    de93a05 View commit details
    Browse the repository at this point in the history

  2. Run the right validation command 

    Co-authored-by: Zach Margolis <[email protected]>
    @aduth @zachmargolis
    aduth and zachmargolis authored Nov 3, 2021
    Configuration menu
    Copy the full SHA
    3f2ad7e View commit details
    Browse the repository at this point in the history

  3. Fix env var condition 

    **Why**: Was previously always skipping
    @aduth
    aduth committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    a14bd02 View commit details
    Browse the repository at this point in the history