Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inventory-item-has-hardware-model Constraint #1088

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions features/fedramp_extensions.feature
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ Examples:
| inventory-item-allows-authenticated-scan |
| inventory-item-and-component-has-public |
| inventory-item-has-function |
| inventory-item-has-hardware-model |
| inventory-item-has-scan-type |
| inventory-item-has-software-name |
| inventory-item-has-software-version |
Expand Down Expand Up @@ -392,6 +393,8 @@ Examples:
| inventory-item-and-component-has-public-PASS.yaml |
| inventory-item-has-function-FAIL.yaml |
| inventory-item-has-function-PASS.yaml |
| inventory-item-has-hardware-model-FAIL.yaml |
| inventory-item-has-hardware-model-PASS.yaml |
| inventory-item-has-scan-type-FAIL.yaml |
| inventory-item-has-scan-type-PASS.yaml |
| inventory-item-has-software-name-FAIL.yaml |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2310,6 +2310,7 @@ approved.</p>
<description>
<p>Legacy Example (No implemented-component).</p>
</description>
<prop name="hardware-model" value="model"/>
<prop name="asset-id" value="unique-asset-ID-01"/>
<prop name="software-version" value="software-version"/>
<prop name="ipv4-address" value="10.1.1.1"/>
Expand Down Expand Up @@ -2365,6 +2366,7 @@ approved.</p>
<description>
<p>Component Inventory Example</p>
</description>
<prop name="hardware-model" value="model"/>
<prop name="asset-id" value="unique-asset-ID-02"/>
<prop name="ipv4-address" value="10.2.2.2"/>
<prop name="ipv6-address" value="0000:0000:0000:0000:0000:ffff:0a02:0202"/>
Expand Down Expand Up @@ -2408,6 +2410,7 @@ approved.</p>
<description>
<p>None.</p>
</description>
<prop name="hardware-model" value="model"/>
<prop name="asset-id" value="unique-asset-ID-03"/>
<prop name="asset-type" value="web-server"/>
<prop name="virtual" value="yes"/>
Expand All @@ -2430,6 +2433,7 @@ approved.</p>
<description>
<p>None.</p>
</description>
<prop name="hardware-model" value="model"/>
<prop name="asset-id" value="unique-asset-ID-04"/>
<prop name="asset-type" value="appliance"/>
<prop name="virtual" value="yes"/>
Expand All @@ -2447,6 +2451,7 @@ approved.</p>
<description>
<p>None.</p>
</description>
<prop name="hardware-model" value="model"/>
<prop name="asset-id" value="unique-asset-ID-05"/>
<prop name="asset-type" value="firewall"/>
<prop name="ipv4-address" value="10.5.5.5"/>
Expand All @@ -2468,6 +2473,7 @@ approved.</p>
<description>
<p>None.</p>
</description>
<prop name="hardware-model" value="model"/>
<prop name="asset-id" value="unique-asset-ID-06"/>
<prop name="ipv4-address" value="10.6.6.6"/>
<prop name="ipv6-address" value="0000:0000:0000:0000:0000:ffff:0a06:0606"/>
Expand All @@ -2493,6 +2499,7 @@ approved.</p>
<description>
<p>None.</p>
</description>
<prop name="hardware-model" value="model"/>
<prop name="asset-id" value="unique-asset-ID-07"/>
<prop name="asset-type" value="switch"/>
<prop name="ipv4-address" value="10.7.7.7"/>
Expand All @@ -2513,6 +2520,7 @@ approved.</p>
<description>
<p>None.</p>
</description>
<prop name="hardware-model" value="model"/>
<prop name="asset-id" value="unique-asset-ID-08"/>
<prop name="asset-type" value="web-server"/>
<prop name="ipv4-address" value="10.8.8.8"/>
Expand All @@ -2537,6 +2545,7 @@ approved.</p>
<description>
<p>Email-Service</p>
</description>
<prop name="hardware-model" value="model"/>
<prop name="asset-id" value="unique-asset-ID-09"/>
<prop name="asset-type" value="email-server"/>
<prop name="ipv4-address" value="10.10.10.100"/>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<system-security-plan xmlns="http://csrc.nist.gov/ns/oscal/1.0" uuid="11111111-2222-4000-8000-000000000000">
<system-implementation>
<inventory-item uuid="11111111-2222-4000-8000-011000000001">
<!-- <prop name="hardware-model" value="model"/> Missing "hardware-model" prop. -->
</inventory-item>
</system-implementation>
</system-security-plan>
Original file line number Diff line number Diff line change
Expand Up @@ -692,6 +692,11 @@
<prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/5-attachments/#system-inventory-approach"/>
<message>Every inventory-item MUST provide remarks to describe the function of the item, either within the inventory-item itself, or within the component linked by the inventory-item.</message>
</expect>
<expect id="inventory-item-has-hardware-model" target="." test="count(prop[@name='hardware-model' ]) >= 1 or count(../component[@uuid=$component-uuid]/prop[@name='hardware-model' ]) >= 1" level="ERROR">
<formal-name>Inventory Item Has Hardware Model</formal-name>
<prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/5-attachments/#system-inventory-approach"/>
<message>In a FedRAMP SSP, each inventory item MUST provide the hardware model either in the inventory item itself or within the linked component.</message>
</expect>
<expect id="inventory-item-has-scan-type" target="." test="count(prop[@name='scan-type' and @ns='http://fedramp.gov/ns/oscal']) >= 1 or count($implemented-component/prop[@name='scan-type' and @ns='http://fedramp.gov/ns/oscal']) >= 1" level="ERROR">
<formal-name>Inventory Item Has Scan Type</formal-name>
<prop namespace="https://docs.oasis-open.org/sarif/sarif/v2.1.0" name="help-url" value="https://automate.fedramp.gov/documentation/ssp/5-attachments/#system-inventory-approach"/>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
test-case:
name: Negative Test for inventory-item-has-hardware-model
description: >-
This test case validates the behavior of constraint
inventory-item-has-hardware-model
content: ../content/ssp-inventory-item-has-hardware-model-INVALID.xml
expectations:
- constraint-id: inventory-item-has-hardware-model
result: fail
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
test-case:
name: Positive Test for inventory-item-has-hardware-model
description: >-
This test case validates the behavior of constraint
inventory-item-has-hardware-model
content: ../../../content/rev5/examples/ssp/xml/fedramp-ssp-example.oscal.xml
expectations:
- constraint-id: inventory-item-has-hardware-model
result: pass
Loading