컨트롤러 추가 #17
Merged
컨트롤러 추가 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baekteun
reviewed
Sep 8, 2022
src/main/java/com/msg/gauth/domain/auth/presentation/AuthController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/msg/gauth/domain/email/presentation/EmailAuthController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/msg/gauth/domain/email/presentation/EmailAuthController.java
Outdated
Show resolved
Hide resolved
baekteun
reviewed
Sep 8, 2022
src/main/java/com/msg/gauth/domain/email/presentation/EmailAuthController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/msg/gauth/domain/email/presentation/EmailAuthController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/msg/gauth/domain/user/presentation/UserController.java
Outdated
Show resolved
Hide resolved
|
머지? |
baekteun
reviewed
Sep 9, 2022
| @DeleteMapping | ||
| public ResponseEntity<Void> logout(){ | ||
| logoutService.execute(); | ||
| return ResponseEntity.ok().build(); |
There was a problem hiding this comment.
https://www.notion.so/HTTP-Status-Code-8b7a1011358b4cbaae39954dc25e3a5e
에다가 Response Status Code 정리해본거 있는데 반영해보싈?
baekteun
reviewed
Sep 9, 2022
| @PostMapping("/signup") | ||
| public ResponseEntity<Void> signUpMember(@RequestBody @Valid SignUpDto signUpDto){ | ||
| signUpService.execute(signUpDto); | ||
| return ResponseEntity.noContent().build(); |
baekteun
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
한일