Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

비밀번호 잊었을 때 변경하는 기능 추가 #43

Merged
merged 5 commits into from
Dec 14, 2022
Merged

비밀번호 잊었을 때 변경하는 기능 추가 #43

merged 5 commits into from
Dec 14, 2022

Conversation

dolong2
Copy link
Member

@dolong2 dolong2 commented Dec 14, 2022 •
edited
Loading

💡 개요

  • 비밀번호를 잊었을 때 변경 기능이 없길래 추가했습니다.

📃 작업내용

  • 패스워드 변경 기능 추가
  • 회원가입시에 해당 emailAuthEntity를 제거하게 수정
  • 패스퉈드 변경시에 해당 emailAuthEntity를 제거하게 수정

🎸 기타

#42

@dolong2 dolong2 added 0️⃣Priority: Critical 우선순위 긴급 ✨ Feature 기능 개발 labels Dec 14, 2022
@dolong2 dolong2 requested a review from baekteun December 14, 2022 07:08
@dolong2 dolong2 self-assigned this Dec 14, 2022
@dolong2 dolong2 linked an issue Dec 14, 2022 that may be closed by this pull request
비밀번호 변경 #42
Closed
@dolong2 dolong2 changed the title 비밀번호 변경 기능 추가 비밀번호 잊었을 때 변경하는 기능 추가 Dec 14, 2022
baekteun
baekteun reviewed Dec 14, 2022
View reviewed changes
src/main/kotlin/com/msg/gauth/domain/user/services/ChangePasswordService.kt Outdated
Comment on lines 20 to 26
fun execute(passwordChangeReqDto: PasswordChangeReqDto){
val emailAuth = emailAuthRepository.findById(userUtil.fetchCurrentUser().email)
.orElseThrow{ throw EmailNotVerifiedException() }
if(!emailAuth.authentication)
throw EmailNotVerifiedException()
val user = (userRepository.findByEmail(emailAuth.email)
?: throw EmailNotVerifiedException())
Copy link
Member

@baekteun baekteun Dec 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 그냥 맨 위에 본인 User 객체 가져와서 변수로 선언해서 쓰는게 더 낫지 않음?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했음

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

유저 존재 여부 판단하는 로직이 필요하려나?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했음

@dolong2 dolong2 merged commit ac25552 into main Dec 14, 2022
@dolong2 dolong2 deleted the feature/change_password branch December 14, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baekteun baekteun baekteun approved these changes

Assignees

@dolong2 dolong2

Labels
0️⃣Priority: Critical 우선순위 긴급 ✨ Feature 기능 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

비밀번호 변경
2 participants
@dolong2 @baekteun