Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ λ§ˆμ΄νŽ˜μ΄μ§€ μ œμž‘ #20

Merged
merged 2 commits into from
Nov 7, 2024
Merged

πŸ”€ λ§ˆμ΄νŽ˜μ΄μ§€ μ œμž‘ #20

merged 2 commits into from
Nov 7, 2024

Conversation

ws-071211
Copy link
Collaborator

πŸ’‘ λ°°κ²½ 및 κ°œμš”

λ§ˆμ΄νŽ˜μ΄μ§€ 퍼블리싱이 ν•„μš”ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • λ§ˆμ΄νŽ˜μ΄μ§€ μ œμž‘
    image

@ws-071211 ws-071211 added 1️⃣ Priority: High μš°μ„ μˆœμœ„ - 상 ✨ Feature μ‹ κ·œ κΈ°λŠ₯ labels Oct 23, 2024
@ws-071211 ws-071211 self-assigned this Oct 23, 2024
Ethen1264
Ethen1264 reviewed Nov 6, 2024
View reviewed changes
src/components/My/molecules/MenuBar/index.tsx
import React from 'react';

const MenuBar = () => {
// const router = useRouter();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석을 ν•΄λ‘” μ΄μœ κ°€ μžˆμ„κΉŒμš”??

src/components/My/molecules/MenuBar/index.tsx
return (
<div className="absolute left-[56px] top-[-16px] flex h-[110px] w-40 flex-col rounded-[10px] bg-gray-100 text-body3 tablet:left-[-164px] tablet:top-2 tablet:drop-shadow-menubar tablet:filter">
<button
// onClick={() => router.push('/my/edit')}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석을 ν•΄λ‘” μ΄μœ κ°€ μžˆμ„κΉŒμš”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μœ„μ˜ 주석도 같은 이유인데 아직 edit νŽ˜μ΄μ§€κ°€ λ―Έμ™„μ„±μ΄μ—¬μ„œ 일단 μ£Όμ„μ²˜λ¦¬ν•΄λ†“μ€ 뒀에 νŽ˜μ΄μ§€ μ™„μ„± ν›„ 주석을 ν•΄μ œν•  μ˜ˆμ •μ΄μ˜€μŠ΅λ‹ˆλ‹€

@ws-071211 ws-071211 merged commit c8b4a3a into develop Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happytaeyoon happytaeyoon happytaeyoon approved these changes

@Ethen1264 Ethen1264 Ethen1264 approved these changes

Assignees

@ws-071211 ws-071211

Labels
1️⃣ Priority: High μš°μ„ μˆœμœ„ - 상 ✨ Feature μ‹ κ·œ κΈ°λŠ₯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ws-071211 @Ethen1264 @happytaeyoon