Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: [#332] DesignSystem / Chip #333

Merged
merged 1 commit into from
May 26, 2024
Merged

πŸ”€ :: [#332] DesignSystem / Chip #333

merged 1 commit into from
May 26, 2024

Conversation

kimsh153
Copy link
Member

πŸ’‘ λ°°κ²½ 및 κ°œμš”

Border Style μ œμž‘ν–ˆμŠ΅λ‹ˆλ‹Ή

스크란샷 2024-05-25 α„‹α…©α„Œα…₯ᆫ 1 36 33

Resolves: #332

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. .env, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "ν™˜κ²½κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@kimsh153 kimsh153 added the 0️⃣ Priority: Critical μš°μ„ μˆœμœ„ - κΈ΄κΈ‰!!!!! label May 24, 2024
@kimsh153 kimsh153 self-assigned this May 24, 2024
@kimsh153 kimsh153 merged commit 0c4c96c into master May 26, 2024
2 checks passed
@kimsh153 kimsh153 deleted the 332-design-system-border-chip branch May 26, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baekteun baekteun baekteun approved these changes

@uuuunseo uuuunseo Awaiting requested review from uuuunseo uuuunseo is a code owner

@shwaaaa shwaaaa Awaiting requested review from shwaaaa shwaaaa is a code owner

@hanjaehyeong hanjaehyeong Awaiting requested review from hanjaehyeong hanjaehyeong is a code owner

@kimkyumbi kimkyumbi Awaiting requested review from kimkyumbi kimkyumbi is a code owner

Assignees

@kimsh153 kimsh153

Labels
0️⃣ Priority: Critical μš°μ„ μˆœμœ„ - κΈ΄κΈ‰!!!!!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

λ””μžμΈ μ‹œμŠ€ν…œ border chip μ œμž‘
2 participants
@kimsh153 @baekteun