Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to tRPC v11 and Next 14.1.4 #124

Merged
merged 6 commits into from
Mar 21, 2024
Merged

Conversation

gillwong
Copy link
Contributor

@gillwong gillwong commented Mar 21, 2024

Using create-t3-app v7.30.0 as reference.

Fixes

@gillwong gillwong added ! Low priority S Small size dependencies Pull requests that update a dependency file labels Mar 21, 2024
@gillwong gillwong self-assigned this Mar 21, 2024
Copy link

github-actions bot commented Mar 21, 2024

📦 Next.js Bundle Analysis for gtd-xxvi-website

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Thirteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/merch/(sales)/(merch)/page 114.5 KB 196.95 KB 56.27% (🟡 +0.48%)
/register/(register)/page 90.07 KB 172.53 KB 49.29% (🟡 +0.48%)
/register/timeslots/page 75.76 KB 158.22 KB 45.21% (🟡 +0.45%)
/merch/(payment)/checkout/[id]/page 45.27 KB 127.73 KB 36.49% (🟡 +0.44%)
/merch/(payment)/complete/page 48.59 KB 131.05 KB 37.44% (🟡 +0.45%)
/(content)/events/gtdfest/page 78.56 KB 161.02 KB 46.01% (🟡 +0.46%)
/merch/(sales)/details/page 85.12 KB 167.58 KB 47.88% (🟡 +0.46%)
/register/(payment)/checkout/page 52.85 KB 135.31 KB 38.66% (🟡 +0.44%)
/register/(payment)/complete/page 48.58 KB 131.04 KB 37.44% (🟡 +0.45%)
/register/details/page 97.58 KB 180.04 KB 51.44% (🟡 +0.48%)
/dashboard/(protected)/(home)/page 92.71 KB 175.17 KB 50.05% (🟡 +0.46%)
/dashboard/(protected)/data/page 47.88 KB 130.33 KB 37.24% (🟡 +0.44%)
/dashboard/(protected)/scan/page 41.69 KB 124.15 KB 35.47% (🟡 +0.44%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Remove manual fix to [sharp issue](lovell/sharp#3967)
because fixed in Next 14.1.4
@gillwong gillwong changed the title Migrate to tRPC v11 Migrate to tRPC v11 and Next 14.1.4 Mar 21, 2024
@gillwong gillwong merged commit 6752485 into main Mar 21, 2024
2 checks passed
@gillwong gillwong deleted the gillbert/migrate-trpc-11 branch March 21, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
! Low priority dependencies Pull requests that update a dependency file S Small size
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm 8.14.3, Next.js 14.1.0 standalone mode, sharp missing
1 participant