impr(nei): simpler check for unspecified power #1232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leagris
added
enhancement
miozune
requested changes
Aug 9, 2022
| @@ -370,13 +370,13 @@ private void drawDescription(GT_Recipe recipe) { | |||
| mPower.computePowerUsageAndDuration(recipe.mEUt, recipe.mDuration); | |||
|
|
|||
| int lineCounter = 0; | |||
| if (mPower.getEuPerTick() > 0) { | |||
| if (!(mPower instanceof UnspecifiedEUPower) && mPower.getEuPerTick() > 0) { | |||
There was a problem hiding this comment.
This completely cut off info for some recipes
|
I agree that the whole class need a good refactor. Closing this PR as it does not address the extend of the refactor need. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better check for unspecified power