Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildscript & apply spotless #1306

Merged
merged 2 commits into from
Aug 27, 2022
Merged

Update buildscript & apply spotless #1306

merged 2 commits into from
Aug 27, 2022

Conversation

eigenraven
Copy link
Member

No other big PRs are open so it's a good opportunity to do this now

@eigenraven eigenraven requested a review from a team August 27, 2022 09:01
@eigenraven
Copy link
Member Author

oops, based off the wrong commit, one sec I'll push a fixed version

@Dream-Master Dream-Master merged commit 6f31720 into master Aug 27, 2022
@Dream-Master Dream-Master deleted the spotless branch August 27, 2022 09:19
@boubou19
Copy link
Member

are the NEI handler changes related to this PR?

@eigenraven
Copy link
Member Author

It was a build error fix, static methods overriding identical non-static method in the superclass

@Dream-Master
Copy link
Member

are the NEI handler changes related to this PR?

where ?

@eigenraven
Copy link
Member Author

huh the first commit looks weird, let me double check what happened during rebase

@Dream-Master
Copy link
Member

or should i reverse it first and we make a new pr after ?

@eigenraven
Copy link
Member Author

One sec, I'm making a fixing pr by reverting this one already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants