Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually hide filled volumetric flask in NEI #331

Merged
merged 3 commits into from
Oct 24, 2020

Conversation

Glease
Copy link
Contributor

@Glease Glease commented Oct 22, 2020

This functionality was added at day 0 but it never worked perfectly. Previously this is called too early that many GT fluid are simply not yet registered.

Hiding filled volumetric flask should do no harm to daily fluid recipe/usage look up. Filled universal cells (or even crystal capsules) are not hidden so they can be used instead.

Extra care was taken to prevent the filter from hiding the empty volumetric flask, which would prevent looking up the recipe of flask itself.

@Glease Glease requested a review from a team October 22, 2020 17:09
Previously this is called too early that many fluid are simply not yet registered.

Signed-off-by: Glease <[email protected]>
@Glease Glease force-pushed the hide-filled-flask branch from f56edb6 to 87abc3b Compare October 22, 2020 17:15
@draknyte1
Copy link
Contributor

Doesn’t GT have hard dependencies on NEI? @optional is kinda pointless cause nowhere else in the mod does so for NEI.

@Glease
Copy link
Contributor Author

Glease commented Oct 22, 2020

I'm not quite sure about that, but the original code does check for NEI, so I just carried it over.

@glowredman
Copy link
Member

glowredman commented Oct 24, 2020

Wouldn't
codechicken.nei.api.API.hideItem(new ItemStack(staticReferenceToVolmetricFlaskItem)); to hide everything and codechicken.nei.api.API.addItemListEntry(new ItemStack(staticReferenceToVolmetricFlaskItem)); to show a empty flask do the trick?
Or codechicken.nei.api.API.setItemListEntries(staticReferenceToVolmetricFlaskItem, java.util.Arrays.asList(new ItemStack(staticReferenceToVolmetricFlaskItem)));

Also, maybe but the handling in gregtech.nei.GT_NEI_DefaultHandler because of this.

@Glease
Copy link
Contributor Author

Glease commented Oct 24, 2020

It seems adding just one override is enough to persuade NEI not to search for subitems.

@Glease Glease requested a review from glowredman October 24, 2020 19:42
@Dream-Master Dream-Master merged commit 42cb8a9 into experimental Oct 24, 2020
@Dream-Master Dream-Master deleted the hide-filled-flask branch October 24, 2020 20:33
eigenraven pushed a commit that referenced this pull request May 24, 2024
* butcher eic recipe time

* oh lol vm time

Former-commit-id: 68ffdf00b9c101b9af30bc11d963a43bdfec847d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants