fix(run-import-js): No longer "importjsd" in v5.0 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When having a hook on window switch to save a file and having a file to fix imports `after save`, the new file content was written to the window I switched to due to the asynchronous call to `importjs`. Now we save the buffer for which the command was invoked and write to that buffer explicitly.
Users might want to hook import-js-fix using either `after-save-hook` or `before-save-hook`. Signed-off-by: Huy Duong <[email protected]>
…ive-buffer Save the buffer associated with the `importjs` command
|
Tested fix locally against my projects and [email protected], LGTM. Thanks to the contributors here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.