Default importjsd to --help instead of start #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently does not work correctly when used like `importjsd --parent-pid n`, which has caused some breakages in our editor plugins. Since this does not seem to be a thing that commander.js likes to do very easily, I think the best path forward at this point is to simply default to `--help` instead. I've already updated the editor plugins to use `importjsd start --parent-pid n`. Fixes #345
|
Thanks Joe! Will you take care of releasing the sublime plugin? |
|
I see you already did. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently does not work correctly when used like
importjsd --parent-pid n, which has caused some breakages in our editor plugins.Since this does not seem to be a thing that commander.js likes to do
very easily, I think the best path forward at this point is to simply
default to
--helpinstead.I've already updated the editor plugins to use
importjsd start --parent-pid n.Fixes #345