✅ update dialog test - composition with transitions

GavinJoyce · Nov 3, 2021 · 8075394 · 8075394
1 parent ac7f8e3
commit 8075394
Showing 1 changed file with 32 additions and 8 deletions.
diff --git a/tests/integration/components/dialog-test.js b/tests/integration/components/dialog-test.js
@@ -315,15 +315,39 @@ module('Integration | Component | <Dialog>', function (hooks) {
   });
 
   module('Composition', function () {
-    todo(
-      'it should be possible to open the Dialog via a Transition component',
-      async function () {}
-    );
+    test('it should be possible to open the Dialog via a Transition component', async function () {
+      this.set('noop', function () {});
 
-    todo(
-      'it should be possible to close the Dialog via a Transition component',
-      async function () {}
-    );
+      await render(hbs`
+        <Transition @show={{true}}>
+          <Dialog @isOpen={{true}} @onClose={{this.noop}} as |d|>
+            <d.Description>Hello</d.Description>
+            <div tabindex="0"></div>
+          </Dialog>
+        </Transition>
+      `);
+
+      assertDialog({ state: DialogState.Visible });
+      assertDialogDescription({
+        state: DialogState.Visible,
+        textContent: 'Hello',
+      });
+    });
+
+    test('it should be possible to close the Dialog via a Transition component', async function () {
+      this.set('noop', function () {});
+
+      await render(hbs`
+        <Transition @show={{false}}>
+          <Dialog @isOpen={{true}} @onClose={{this.noop}} as |d|>
+            <d.Description>Hello</d.Description>
+            <div tabindex="0"></div>
+          </Dialog>
+        </Transition>
+      `);
+
+      assertDialog({ state: DialogState.InvisibleUnmounted });
+    });
   });
 
   module('Keyboard interactions', function () {