✨ <Dialog/> Set return focus on clicked element #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed and why
PR adds
setReturnFocus
option fromfocus-trap
where we can explicitly set which element should be focus after deactivation. Default behavior is to return focus to the element which opened the dialog (trigger button).When there is no overlay, and the user clicks outside the dialog, focus will be set to the element which is clicked by the user (see test).
By the way of implementing it, I figure out that
focus-trap
also uses similar pattern to detectoutside-click
, so far we used dedicated modifier (outside-click-modifier
) as we use it only here I think we can usefocus-trap
and safely removeoutside-click-modifier
from dependency list.