Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Feature: listbox transitions #83

Merged
merged 2 commits into from
Sep 16, 2021
Merged

✨ Feature: listbox transitions #83

merged 2 commits into from
Sep 16, 2021

Conversation

dmcnamara-eng
Copy link
Collaborator

✨ What Changed & Why

  1. ✨ Add dummy page for listbox with transition
  2. ✅ implement test "test should be possible to wrap the Listbox.Options with a Transition component"

👹 Before

N/A

😇 After

after

🌈 Testing

  1. Check out this branch
  2. Run ember serve
  3. Navigate to http://localhost:4200/listbox/listbox-with-transition
  4. Observe listbox with transition and enter/leave

@dmcnamara-eng dmcnamara-eng force-pushed the feature/listbox-transitions branch from bf8a28f to 1854f46 Compare September 8, 2021 15:53
@alexlafroscia
Copy link
Collaborator

Great, to have more code examples -- thanks!

@alexlafroscia alexlafroscia merged commit 7794733 into GavinJoyce:master Sep 16, 2021
@alexlafroscia alexlafroscia added the documentation Improvements or additions to documentation label Sep 16, 2021
@dmcnamara-eng dmcnamara-eng deleted the feature/listbox-transitions branch October 6, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmcnamara-eng @alexlafroscia