Ditch render-modifiers #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
changed the title
NullVoxPopuli
force-pushed
the
ditch-render-modifiers
branch
from
94f9bd0 to
0407b1c
Compare
GavinJoyce
reviewed
Oct 3, 2021
| * https://github.com/pzuraq/ember-could-get-used-to-this/blob/master/addon/-private/modifiers.js | ||
| * | ||
| * Because: | ||
| * - we don't want to *force* folks into use ember-could-get-used-to-this |
There was a problem hiding this comment.
I'm not against including this here, just wondering why we don't want to depend on ember-could-get-used-to-this?
There was a problem hiding this comment.
we absolutely could! what other things might we want to use ember-could-get-used-to-this for?
(I think we need to move ember-could-get-used-to-this in to adopted-addons, or specifically extract out the function-modifier bit to a new addon and have that included everywhere -- maybe call it ember-default-modifier-manager-polyfill or something related to the matching RFC 🤷)
|
superseded by #116 |
|
superseded by: #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - exploration for now
Begins #88