WIP: Setup poetry in pyproject.toml #1055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translating the Python specific dependencies inside the conda environment.yml file into poetry. Project metadata and required dependencies are copied from setup.py. There are also optional dependencies for building sphinx documentation and development specific dependencies for testing.
Only installing GMT and make via conda, plus poetry just to make things easy. The PyGMT package and all the necessary Python dependencies are installed using poetry.
|
Just in case you don't notice it: poetry doesn't work well with setuptools_scm, so the version is |
weiji14
commented
Mar 14, 2021
| @@ -1,3 +1,47 @@ | |||
| [tool.poetry] | |||
| name = "pygmt" | |||
| version = "0.3.1" | |||
There was a problem hiding this comment.
Just in case you don't notice it: poetry doesn't work well with setuptools_scm, so the version is
v0.3.1, notv0.3.1.dev100+xxxxx.
Yeah I realize that this hardcoding is bad. There's https://github.com/mtkennerly/poetry-dynamic-versioning but doesn't look like a very official solution.
To be honest, this PR isn't intended to replace setup.py just yet. Just wanted to see if mixing conda and poetry might shave a few minutes off the CI test time.
7 tasks
|
Closing this PR. May reopen it in the future if there's any interest in using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Initializing poetry to see if it can speed up the install step in our Continuous Integration.
condaworks in serial and can be a bit slow, whilepoetrycan install things in parallel. The idea here is to usecondaonly for non-Python packages (i.e. GMT and make), andpoetryfor Python dependencies (e.g. numpy, pandas, etc).Notes:
poetry install --no-devto get only the minimum required dependencies for PyGMTpoetry installto get both minimum and development dependencies (e.g. pytest, black, codecov, etc)poetry install --no-dev --extras docsto install minimum and dependencies for building docs (e.g. sphinx, etc)poetry install --extras docsto get all of the aboveAddresses #584, may help with #690
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version