Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the build package to build sdist and wheel distributions #1823

Merged
merged 2 commits into from
Mar 19, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 16, 2022

Description of proposed changes

Fixes #1797.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Mar 16, 2022
@seisman seisman added this to the 0.6.1 milestone Mar 16, 2022
@seisman seisman force-pushed the deprecate-setup-build branch from 8b609ba to 732cce1 Compare March 16, 2022 05:09
@seisman seisman force-pushed the deprecate-setup-build branch from ba25ca1 to 079753f Compare March 17, 2022 04:01
mamba install gmt=6.3.0 \
numpy pandas xarray netCDF4 packaging matplotlib
mamba install gmt=6.3.0 numpy pandas xarray netCDF4 packaging \
build matplotlib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit unrelated, but why is matplotlib needed in the cache_data workflow? Isn't this GitHub Actions workflow just used to download files?

I see that the matplotlib dependency was added at 270e3ea in #1310, but can't see exactly why this is needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from matplotlib.testing.compare import compare_images

matplotlib is imported in testing.py so when we run the download_test_data function, matplotlib must be imported.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. Seems like that import line could just be put inside the check_figures_equal function, but let's just keep things the way it is right now.

@@ -34,7 +34,7 @@ jobs:
python-version: '3.10'

- name: Install dependencies
run: python -m pip install setuptools wheel
run: python -m pip install build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and just noting that we should double check that the wheel and source files on TestPyPI look ok once this PR is merged.

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me on Linux. Might pay to know if this works locally on macOS and Windows as well, but the CI does look ok.

@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Mar 18, 2022
@seisman seisman merged commit 813142b into main Mar 19, 2022
@seisman seisman deleted the deprecate-setup-build branch March 19, 2022 04:12
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python setup.py gives deprecation warnings
2 participants