-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the build package to build sdist and wheel distributions #1823
Conversation
8b609ba
to
732cce1
Compare
ba25ca1
to
079753f
Compare
mamba install gmt=6.3.0 \ | ||
numpy pandas xarray netCDF4 packaging matplotlib | ||
mamba install gmt=6.3.0 numpy pandas xarray netCDF4 packaging \ | ||
build matplotlib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pygmt/pygmt/helpers/testing.py
Line 8 in 8fe2d33
from matplotlib.testing.compare import compare_images |
matplotlib is imported in testing.py
so when we run the download_test_data
function, matplotlib must be imported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok. Seems like that import
line could just be put inside the check_figures_equal
function, but let's just keep things the way it is right now.
@@ -34,7 +34,7 @@ jobs: | |||
python-version: '3.10' | |||
|
|||
- name: Install dependencies | |||
run: python -m pip install setuptools wheel | |||
run: python -m pip install build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and just noting that we should double check that the wheel and source files on TestPyPI look ok once this PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for me on Linux. Might pay to know if this works locally on macOS and Windows as well, but the CI does look ok.
Description of proposed changes
Fixes #1797.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version