-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move gmt from requirements.txt to CI scripts instead #343
Move gmt from requirements.txt to CI scripts instead #343
Conversation
The requirements.txt file is a standard file used by pip to install Python packages, and it is confusing to use it for installing conda packages.
As far as I can see, all the packages in the requirements.txt and requirements-dev.txt can be installed via pip, except |
Yes, the first problem is that the Second problem is that our CI build actually uses the |
Move the conda gmt=6.0.0rc4 requirement from requirement.txt to the CONDA_INSTALL_EXTRA environment variable in our Travis and Azure build scripts.
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/gmt/pygmt/3qtvtcmrl |
This raises an interesting issue that we'll have to think about. If we publish to PyPI, even though the install would work, the user will get an error on import because GMT hasn't been installed as well. Which means that our PyPI packages are almost useless unless we bundle GMT and other binaries into a wheel (which I'm not looking forward to doing). It would be very frustrating for non-GMT users to I don't have a solution for this. If anyone has some thoughts, that would be great! |
Includes GenericMappingTools/pygmt#343 that will hopefully address https://github.com/dependabot/feedback/issues/482. There's also the new `makecpt` wrapper added in GenericMappingTools/pygmt#329. Need to temporarily pin dask at 0.12.3 because of some multiprocessing error. - [GMT](https://github.com/GenericMappingTools/gmt) from 6.0.0rc3 to 6.0.0rc5 - [Release notes](https://github.com/GenericMappingTools/gmt/releases/tag/6.0.0rc5) - [Commits](GenericMappingTools/gmt@6.0.0rc3...6.0.0rc5) - [PyGMT](https://github.com/GenericMappingTools/pygmt) from 0.0.1a0-43-g421e10d to 0.0.1a0-57-g7590d4a. - [Commits](weiji14/pygmt@0.0.1a0-43-g421e10d...0.0.1a0-57-g7590d4a)
Description of proposed changes
Edit: Simply placing
gmt
in our Continuous Integration (CI) scripts'CONDA_INSTALL_EXTRA
environment variable so that therequirements.txt
file remains valid forpip
.Renaming instances ofrequirements.txt
->conda-requirements.txt
, andrequirements-dev.txt
->conda-requirements-dev.txt
.Therequirements.txt
file is a standard file used by pip to install Python packages, but we use it here for installing conda packages?! There are actually some automated bots/services that gets confused by thisrequirements.txt
file, thinking it should use if to install PyPI packages but fails because it's not meant for that.May want to raise this upstream too at https://github.com/fatiando/continuous-integration.Needed for Zeit Now continuous documentation PR at #344, may help resolve weiji14/deepbedmap#153
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.