Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.6 support #699

Merged
merged 2 commits into from
Nov 21, 2020
Merged

Drop Python 3.6 support #699

merged 2 commits into from
Nov 21, 2020

Conversation

seisman
Copy link
Member

@seisman seisman commented Nov 21, 2020 •
edited
Loading

Description of proposed changes

  • Remove Python 3.6 from our CI jobs
  • Bump the minimum required Python version to 3.7 in the documentation
  • Remove Python 3.6 from setup.py

Address #690.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Notes

  • You can write /format in the first line of a comment to lint the code automatically

@seisman seisman added the maintenance Boring but important stuff for the core devs label Nov 21, 2020
@seisman seisman added this to the 0.2.2 milestone Nov 21, 2020
@seisman
Copy link
Member Author

seisman commented Nov 21, 2020

Do we all agree that the next release will be v0.3.0? If so I will change the projects and milestone.

@seisman seisman requested a review from weiji14 November 21, 2020 02:15
weiji14
weiji14 reviewed Nov 21, 2020
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor things, and yes 👍 for going with v0.3.0.

.github/workflows/ci_tests.yaml Outdated Show resolved Hide resolved
doc/install.rst Outdated Show resolved Hide resolved
@weiji14 weiji14 modified the milestones: 0.2.2, 0.3.0 Nov 21, 2020
@seisman seisman merged commit 3fb3d7a into master Nov 21, 2020
@seisman seisman deleted the drop-py36 branch November 21, 2020 04:57
@seisman seisman mentioned this pull request Nov 21, 2020
Closed
5 tasks
@weiji14 weiji14 mentioned this pull request Nov 22, 2020
Closed
@weiji14 weiji14 added deprecation Deprecating a feature and removed maintenance Boring but important stuff for the core devs labels Feb 14, 2021
@seisman seisman mentioned this pull request Dec 19, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees
No one assigned
Labels
deprecation Deprecating a feature
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@seisman @weiji14