Use gmtool after configuration has been done #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyal-lezmy
suggested changes
Feb 2, 2017
plugin/build.gradle
Outdated
| @@ -87,7 +87,7 @@ dependencies { | |||
| } | |||
|
|
|||
| group = 'com.genymotion' | |||
| version = '1.3' | |||
| version = '1.4' | |||
There was a problem hiding this comment.
please don't bump the version
| gmtool.setConfig(config) | ||
|
|
||
| project.genymotion.config.version = gmtool.getVersion() |
There was a problem hiding this comment.
This should be outside the if (line 250) as it is needed whatever the config is set or not.
In order to be able to use the plugin with configuration in the local.properties and without putting gmtool in the path, move some codes to be sure gmtool has been configured before using it to retrieve its version.
sgaland
force-pushed
the
hotfix/gmtool_used_before_configuration
branch
from
8decfe3 to
c61af1c
Compare
|
Thanks for the modification. We need to find a way to test this bug efficiently before merging. I'll try to look at it next week but feel free to propose if you have time. |
eyal-lezmy
changed the base branch from
master
to
integration/fix-gmtool-config
eyal-lezmy
approved these changes
Aug 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to use the plugin with configuration in the local.properties and without putting gmtool in the path, move some codes to be sure gmtool has been configured before using it to retrieve its version.
It works on my side for my use case, please review this to be sure there is no side effect I missed.