docblocks completed, translation fixes, whoop compatibility bug fixes #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viruthagiri
changed the title
| @@ -28,18 +28,32 @@ | |||
| * | |||
| * @since 0.0.1 | |||
| * @package BuddyPress_Compliments | |||
| * | |||
| * @global object $bp BuddyPress instance. | |||
| * @global object $wpdb WordPress db object. | |||
| */ | |||
| function bp_compliments_init() { | |||
| global $wpdb, $bp; | |||
| // get plugin version from plugin data. | |||
| $plugin_data = get_plugin_data( __FILE__ ); | |||
There was a problem hiding this comment.
Giri, this is not the best way to get the version number, the function get_plugin_data will have to read the file contents just simply to get the version number when you could simply just write it again in the file, please don't ever do it this way.
Stiofan
pushed a commit
that referenced
this pull request
Jun 29, 2015
docblocks completed, translation fixes, whoop compatibility bug fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.