Skip to content

Commit

Permalink
remove SearchServicesConfig plugin (#84)
Browse files Browse the repository at this point in the history
  • Loading branch information
@allyoucanmap
allyoucanmap authored Mar 5, 2021
1 parent 27a8c2d commit 53b9be1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion geonode_mapstore_client/static/geonode/js/ms2/utils/ms2_map_viewer_plugins.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ var MS2_MAP_PLUGINS = {
"Notifications",
"Timeline",
"Playback",
"SearchServicesConfig",
{
"name": "Share",
"cfg": {
Expand Down
1 change: 0 additions & 1 deletion geonode_mapstore_client/static/geonode/js/ms2/utils/ms2_viewer_plugins.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ var MS2_PLUGINS = {
"Redo",
"BurgerMenu",
"MapFooter",
"SearchServicesConfig",
{
"name": "Print",
"cfg": {
Expand Down

8 comments on commit 53b9be1

@dpadron
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to re-enable this plugins for version 2.1.2. It is a very useful function. I do not understand why it was suppressed.
Thanks for your attention

@giohappy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpadron were you using it to configure your custom geolocation service?

@dpadron
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi giohappy,
If I use it to perform custom searches.
Is it possible to reactivate it? Thanks for your attention

@giohappy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpadron it was removed because it was confusing to many users.
We can consider its reactivation if we have funds to detach the configuration button from the underlying plugin. If we had this we could activate it only for maps and only in editing mode:

  • only for maps because the configuration is stored inside a map configuration, which is not available for single layers
  • only in editing mode because it's only meaningful to map editors. A causal read-only user will find it confusing and, in any case, he can't save it.

@dpadron
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giohappy I understand the need to correct the logic to improve this plugin. Tell me what we can do?

@giohappy
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can either send PRs to MapStore2 and this repo with the required improvements or spondor their development.

@dpadron
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok Thanks @giohappy for your answer

@allyoucanmap
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dpadron @giohappy ,
before to make additional changes I would like to link this answer #109 (review) that could be useful for this particular topic

Please sign in to comment.