Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client - Layout improvement for filter panel (sticky panel) #108

Merged
merged 33 commits into from
Apr 12, 2021

Conversation

luorlandini
Copy link

@luorlandini luorlandini commented Apr 2, 2021

Description

  • fix alignement between the cards container and the headers (verify padding and structure of grid layout)
  • make the panel sticky and with it own scroolbar (similar to datail panel)

@afabiani
Copy link
Member

afabiani commented Apr 6, 2021

@luorlandini I see some conflicts

Copy link
Collaborator

@allyoucanmap allyoucanmap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there ares some style issues from a quick review:

  • horizontal scrollbar in the page probably due to use of rows and cols component outside of a container component
  • the filter panel is not filling all the available space

image

@luorlandini
Copy link
Author

@allyoucanmap about horizontal scrollbar in the page, is due to the negative margin of component row, I'm going to fix it
about filter panel, has a max-height, to simulate the mockup solution

@giohappy
Copy link

giohappy commented Apr 7, 2021

@allyoucanmap about horizontal scrollbar in the page, is due to the negative margin of component row, I'm going to fix it
about filter panel, has a max-height, to simulate the mockup solution

@luorlandini ket's make it the same as the right sidebar (preview). Full height, sticky

@luorlandini luorlandini requested a review from allyoucanmap April 8, 2021 14:09
@allyoucanmap allyoucanmap merged commit bd1771d into GeoNode:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants