#1603: Fix - Download button visibility with url and view only perms #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giohappy
previously approved these changes
Oct 30, 2023
giohappy
reviewed
Nov 6, 2023
| if ((isEmpty(_resource?.download_urls) && !_resource?.perms?.includes('download_resourcebase')) || (!isButton && isNotAjaxSafe)) { | ||
| if ((isEmpty(_resource?.download_urls) && !_resource?.perms?.includes('download_resourcebase')) | ||
| || !_resource?.perms?.includes('download_resourcebase') | ||
| || (!isButton && isNotAjaxSafe) |
There was a problem hiding this comment.
Are we showing a different icon in case of isNotAjaxSafe @dsuren1? I think it should still be shown as download even if it's not handled over ajax.
There was a problem hiding this comment.
@giohappy Yes, currently 
(AJAX safe) and 
(AJAX not safe)
I think it should still be shown as download even if it's not handled over ajax.
Sure but should we also show when sourceType: REMOTE?
There was a problem hiding this comment.
Sure but should we also show image when sourceType: REMOTE?
No, should be used for REMOTE (only)
allyoucanmap
approved these changes
Nov 9, 2023
giohappy
added a commit
that referenced
this pull request
Nov 13, 2023
* #1596 - Catalog page path configuration (#1597) * [create-pull-request] automated change (#1599) Co-authored-by: allyoucanmap <[email protected]> * Fix ajax safe download button render (#1601) * #1598: Facet fixes on different filter type (#1600) * [create-pull-request] automated change (#1602) Co-authored-by: allyoucanmap <[email protected]> * #1594 - Enhance filter panel and accordion with configurable options (#1595) * [create-pull-request] automated change (#1605) Co-authored-by: allyoucanmap <[email protected]> * #1607: Tabs component enhancement (#1608) * [create-pull-request] automated change (#1609) Co-authored-by: allyoucanmap <[email protected]> * #1603: Fix - Download button visibility with url and view only perms (#1606) * [create-pull-request] automated change (#1610) Co-authored-by: allyoucanmap <[email protected]> * Fixes #1612 - Implement Django admin management for MS Search services (#1613) * Implement django admin management search services * Implement django admin management search services * Implement django admin management search services * Implement django admin management search services * Implement django admin management search services * Implement django admin management search services * Fix typo * Improvements to model help texts * fixed cache name and key * Improvements to hel texts --------- Co-authored-by: Giovanni Allegri <[email protected]> Co-authored-by: G. Allegri <[email protected]> --------- Co-authored-by: Suren <[email protected]> Co-authored-by: geosolutions-pr-generator[bot] <87376048+geosolutions-pr-generator[bot]@users.noreply.github.com> Co-authored-by: allyoucanmap <[email protected]> Co-authored-by: mattiagiupponi <[email protected]>
giohappy
pushed a commit
that referenced
this pull request
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the download button visibility with
download_urlspresent and withviewonly permsIssue