Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 4.2.x] #1627 Review remote pdf preview (#1642) #1643

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

allyoucanmap
Copy link
Collaborator

It is not possible to prevent the popup download If a remote PDF responds with Content-Disposition that triggers it and to fix this behaviour we are introducing following changes:

  • remote documents will not be previewed in the catalogue detail panel. We will show the thumbnail or the default icon.
  • for all pdf files we will perform a direct request followed by a proxy request only in case the first fails. If both fails we will show the metadata preview

* review remote pdf request

* restore app utils
@giohappy giohappy added this to the 4.2.0 milestone Dec 6, 2023
@giohappy giohappy merged commit 05e1be5 into GeoNode:4.2.x Dec 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The fix for the remote pdf preview has broken the preview of local documents
2 participants