Variogram estimation from multiple fields #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LSchueler ready for review! 🥰 |
LSchueler
requested changes
Sep 23, 2020
There was a problem hiding this comment.
That is actually quite nice syntactic sugar. I think I like it. Although it makes it even more complicated dealing with all the different field shapes internally. But that will hopefully one day change with version 2.0.
Shouldn't this be extended to the structured variogram estimation? - I imagine this could lead to confusions, when someone changes from unstructured to structured fields.
And some minor requests in the code comments.
Cheers!
| fields = [field1, field2] | ||
|
|
||
| ############################################################################### | ||
| # Now we estimate the variograms for both fields individual and then again |
|
|
||
| plt.plot(bin_center, gamma1, label="field 1") | ||
| plt.plot(bin_center, gamma2, label="field 2") | ||
| plt.plot(bin_center, gamma, label="field joint") |
There was a problem hiding this comment.
"field joint" => "joined fields" ?
|
This was added in the Closing this PR in favor of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR a new option for unstructured variogram estimation is added:
You can now estimate one variogram from multiple fields on the same point-set. This could be useful to estimate a single variogram to describe multiple realizations of the same process.
Example:
In addition, these fields can have missing values, denoted by a new
no_dataargument.Checklist: