-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor CI fixes #117
minor CI fixes #117
Conversation
MuellerSeb
commented
Dec 2, 2020
- rewrite triggers
- only master and develop are running
- only PRs to develop (all origins)
- workflow_dispatch fix
- pin version of cibuildwheel
- test.pypi for develop and master
…d all PRs to develop (master only gets PR from develop)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixing CIBW version is fine, testing the deployment of the master branch too, but the conditions at the beginning will again cause internal PRs to be built and tested twice.
Actually this shouldn't happen.
|
I'm not exactly sure how the event |
and "synchronize" refers to any update in the source branch (link) So I think it should work. Maybe just try? |
That's really missing in the Actions doc, right? - Yeah, let's just try it. |
Yeah.. the docs are really missing some important informations.. guess it's still work in progress. But hey, they are building a hell of a machine there! |