Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor CI fixes #117

Merged
merged 3 commits into from
Dec 3, 2020
Merged

minor CI fixes #117

merged 3 commits into from
Dec 3, 2020

Conversation

MuellerSeb
Copy link
Member

  • rewrite triggers
    • only master and develop are running
    • only PRs to develop (all origins)
  • workflow_dispatch fix
  • pin version of cibuildwheel
  • test.pypi for develop and master

@MuellerSeb MuellerSeb added this to the 1.3 milestone Dec 2, 2020
@MuellerSeb MuellerSeb requested a review from LSchueler December 2, 2020 16:45
@MuellerSeb MuellerSeb self-assigned this Dec 2, 2020
@MuellerSeb MuellerSeb changed the base branch from master to develop December 2, 2020 16:45
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing CIBW version is fine, testing the deployment of the master branch too, but the conditions at the beginning will again cause internal PRs to be built and tested twice.

@MuellerSeb
Copy link
Member Author

... the conditions at the beginning will again cause internal PRs to be built and tested twice.

Actually this shouldn't happen.

  1. When pushed to a branch:
  • "master"/"develop" -> triggered
  • every other branch -> not triggered
  1. PRs should only be against "master"/"develop" (at least that is what we do up to now)
  • only trigger if base branch is "develop"
  • when base branch is "master", PR should come from "develop"
    • then PR is not triggering
    • develop is triggered as a branch
  • when branch is other than "master"/"develop" nothing is triggered until a PR is opened against "develop"

@LSchueler
Copy link
Member

I'm not exactly sure how the event pull_request is defined. Are you sure that every push to a branch which has an open PR triggers pull_request? - Otherwise, with your suggestion, the CI would only run once, when the PR is opened from a forked repo.

@MuellerSeb
Copy link
Member Author

https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#pull_request

Note: By default, a workflow only runs when a pull_request's activity type is opened, synchronize, or reopened. To trigger workflows for more activity types, use the types keyword.

and "synchronize" refers to any update in the source branch (link)

So I think it should work. Maybe just try?

@LSchueler
Copy link
Member

That's really missing in the Actions doc, right? - Yeah, let's just try it.

@MuellerSeb
Copy link
Member Author

That's really missing in the Actions doc, right? - Yeah, let's just try it.

Yeah.. the docs are really missing some important informations.. guess it's still work in progress. But hey, they are building a hell of a machine there!

@MuellerSeb MuellerSeb merged commit b56a1b3 into develop Dec 3, 2020
@MuellerSeb MuellerSeb deleted the ci_fixes branch December 3, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants