Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated scipy method pinv2 #247

Merged
merged 1 commit into from
Aug 6, 2022
Merged

Remove deprecated scipy method pinv2 #247

merged 1 commit into from
Aug 6, 2022

Conversation

LSchueler
Copy link
Member

With Scipy v1.9 GSTools fails to import pinv2, as reported in #246 .

According to the PR both methods pinv and pinv2 have been using the same algorithms for a long time. Thus, I simply deleted the option pinv2.

According to the PR
scipy/scipy#13831
Both methods pinv and pinv2 have been using the same algorithms for a
long time. Thus, I simply deleted the option pinv2.
@LSchueler LSchueler requested a review from MuellerSeb August 4, 2022 12:31
@LSchueler LSchueler self-assigned this Aug 4, 2022
@LSchueler LSchueler added the bug Something isn't working label Aug 4, 2022
@LSchueler
Copy link
Member Author

The failed tests are not a problem of this PR and they are fixed with PR #248 .

@LSchueler
Copy link
Member Author

Now, all CI runs fail due to the updated scipy-package. I'll just merge this right now.

@LSchueler LSchueler merged commit 51204f4 into main Aug 6, 2022
@MuellerSeb MuellerSeb added this to the v1.4 milestone Aug 9, 2022
@MuellerSeb MuellerSeb deleted the pinv2-deprecated branch August 9, 2022 12:43
@MuellerSeb MuellerSeb linked an issue Aug 9, 2022 that may be closed by this pull request
@MuellerSeb MuellerSeb linked an issue Aug 11, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requirements for Scipy Innacurate scipy.linalg.pinv2 not available in scipy 1.9
2 participants