Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pykrige: fix passed variogram in case of geo-coord #254

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

MuellerSeb
Copy link
Member

@MuellerSeb MuellerSeb commented Aug 10, 2022

PyKrige was not able to use geographical coordinates with a GSTools CovModel. This is the GSTools part of the fix.

See: GeoStat-Framework/PyKrige#217 and #235

@MuellerSeb MuellerSeb self-assigned this Aug 10, 2022
@MuellerSeb MuellerSeb added bug Something isn't working enhancement New feature or request external problem labels Aug 10, 2022
@MuellerSeb MuellerSeb added this to the v1.4 milestone Aug 10, 2022
@MuellerSeb MuellerSeb linked an issue Aug 10, 2022 that may be closed by this pull request
@MuellerSeb MuellerSeb requested a review from LSchueler August 10, 2022 13:14
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a solid solution :-) 👍

@LSchueler LSchueler merged commit 8122d6b into main Aug 12, 2022
@MuellerSeb MuellerSeb deleted the pykrige_latlon_fix branch August 12, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request external problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I14Y: latlon support for PyKrige interface
2 participants