Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary coding, use a few f-strings #283

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Nov 11, 2022

These edits were automated using:

pyupgrade --py37-plus `find . -name "*.py*"`

and does:

  • Remove unnecessary # -*- coding: utf-8 -*- comment, since PEP 3120 declared UTF-8 as the default source encoding since Python 3.0
  • Convert a few f-strings
  • Add missing r prefix for a raw string with \ used for math markup

Copy link
Member

@MuellerSeb MuellerSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what I like about OSS: people care about it! Thanks for that. One minor comment about the usage of f-strings in cython.

src/gstools/variogram/estimator.pyx Outdated Show resolved Hide resolved
Copy link
Member

@MuellerSeb MuellerSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for this cleanup @mwtoews

@MuellerSeb MuellerSeb merged commit bce1ab6 into GeoStat-Framework:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants