Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print deprecation warnings for Python 2.7 and 3.4 #41

Merged
merged 1 commit into from
Nov 8, 2019
Merged

Print deprecation warnings for Python 2.7 and 3.4 #41

merged 1 commit into from
Nov 8, 2019

Conversation

LSchueler
Copy link
Member

@LSchueler LSchueler commented Nov 8, 2019 •
edited
Loading

Maybe this is coming a bit late, but we should soon make a new release with the deprecation warnings of this pull request and give our users a head start with upgrading their Python versions.

For the discussion about dropping the support, see issue #40.

@LSchueler LSchueler requested a review from MuellerSeb November 8, 2019 11:07
@LSchueler LSchueler self-assigned this Nov 8, 2019
@LSchueler LSchueler added the FutureWarning Aim is to prevent FutureWarnings when they appear. label Nov 8, 2019
@LSchueler LSchueler added this to the 1.1.1 milestone Nov 8, 2019
MuellerSeb
MuellerSeb approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@MuellerSeb MuellerSeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
With the py38support branch we will also drop support for py34. So first drop that, than py27 at the end of the year.

@MuellerSeb
Copy link
Member

Lets make a 1.1.1 release after this merge.

@LSchueler LSchueler merged commit ce21c35 into master Nov 8, 2019
@MuellerSeb
Copy link
Member

You should add this to the changelog and refer to this PR.

@LSchueler
Copy link
Member Author

Thanks for pointing that out!

@LSchueler LSchueler deleted the deprecationwarnings branch November 8, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MuellerSeb MuellerSeb MuellerSeb approved these changes

Assignees

@LSchueler LSchueler

Labels
FutureWarning Aim is to prevent FutureWarnings when they appear.
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@LSchueler @MuellerSeb