Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fully functional edit experience for index fields #4204

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Fully functional edit experience for index fields #4204

merged 5 commits into from
Jul 8, 2024

Conversation

kaise-lafrai
Copy link
Contributor

@kaise-lafrai kaise-lafrai commented Jun 27, 2024 •
edited
Loading

fixes [org/repo/issue#]

  • Test coverage exists
  • Documentation exists

QA Steps

  • Navigate to form /node/add/data?schema=data-dictionary
  • Select Add index
  • Select Add field
  • Enter value for Name and Length
  • Select Add
  • Confirm field was added
  • Select gear icon
  • Modify the Name/Length
  • Select Save
  • Confirm new values are saved
  • Select gear icon
  • Select Delete index field
  • Confirm field is removed
  • Continue testing by adding multiple fields and editing/deleting at random spots.
  • At the end confirm you are able to submit the index and save the node
  • Go back to the saved node to edit and confirm all fields and data exists
  • Add dictionary fields and indexes to confirm the entirety of the form works as expected.

@kaise-lafrai kaise-lafrai self-assigned this Jun 27, 2024
@kaise-lafrai kaise-lafrai requested a review from rovcase June 27, 2024 14:04
@kaise-lafrai kaise-lafrai force-pushed the Data-Dictionary-Index-Working branch from dbcf8d9 to 4e9882e Compare June 27, 2024 15:32
@kaise-lafrai kaise-lafrai force-pushed the Data-Dictionary-Index-Field-Edit branch from beaf09d to f29f466 Compare June 27, 2024 15:33
@kaise-lafrai kaise-lafrai force-pushed the Data-Dictionary-Index-Field-Edit branch from f29f466 to c61206d Compare June 27, 2024 15:35
@kaise-lafrai kaise-lafrai marked this pull request as ready for review July 2, 2024 21:10
rovcase
rovcase approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@rovcase rovcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work thanks! Merging this and closing respective PR/ticket as it's an ongoing feature branch. Thanks!

@rovcase rovcase merged commit 9ec37cd into Data-Dictionary-Index-Working Jul 8, 2024
9 checks passed
@rovcase rovcase deleted the Data-Dictionary-Index-Field-Edit branch July 8, 2024 20:51
dmundra pushed a commit that referenced this pull request Aug 9, 2024
@kaise-lafrai @dmundra
Fully functional edit experience for index fields (#4204)
dd6ebf8
dmundra pushed a commit that referenced this pull request Sep 6, 2024
@kaise-lafrai @dmundra
Fully functional edit experience for index fields (#4204)
585d771
beeyayjay pushed a commit that referenced this pull request Jan 6, 2025
@kaise-lafrai
Fully functional edit experience for index fields (#4204)
55f23a4
beeyayjay pushed a commit that referenced this pull request Jan 6, 2025
@kaise-lafrai
Fully functional edit experience for index fields (#4204)
e529acc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rovcase rovcase rovcase approved these changes

Assignees

@kaise-lafrai kaise-lafrai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaise-lafrai @rovcase