Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WCMS-20047: Data Dictionary Documentation #4271

Merged
merged 14 commits into from
Sep 6, 2024
Merged

WCMS-20047: Data Dictionary Documentation #4271

merged 14 commits into from
Sep 6, 2024

Conversation

rovcase
Copy link
Contributor

@rovcase rovcase commented Sep 3, 2024

Fixes [issue#]

Describe your changes

QA Steps

  • Add manual QA steps in checklist format for a reviewer to perform. Be as specific as possible, provide examples if appropriate.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added documentation

@dmundra dmundra self-requested a review September 4, 2024 20:01
dmundra
dmundra requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@dmundra dmundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rovcase looking good. Left you comments to consider for the data dictionary page. Let me know what you think.

docs/source/user-guide/guide_data_dictionaries.rst Outdated Show resolved Hide resolved
docs/source/user-guide/guide_data_dictionaries.rst Show resolved Hide resolved
docs/source/user-guide/guide_data_dictionaries.rst Outdated Show resolved Hide resolved
@rovcase
Copy link
Contributor Author

rovcase commented Sep 6, 2024

@rovcase looking good. Left you comments to consider for the data dictionary page. Let me know what you think.

Tysm for the look over, added your changes and should be good now.

@dmundra
Copy link
Contributor

dmundra commented Sep 6, 2024

@rovcase looking good. Left you comments to consider for the data dictionary page. Let me know what you think.

Tysm for the look over, added your changes and should be good now.

Thank you @rovcase. I think one more fix (I left a reply on a previous comment) and you should be good to go.

@dmundra dmundra merged commit 7b09fdd into Data-Dictionary-Index-Working Sep 6, 2024
1 of 8 checks passed
@dmundra dmundra deleted the WCMS-20047 branch September 6, 2024 18:22
dmundra pushed a commit that referenced this pull request Sep 6, 2024
@rovcase @dmundra
WCMS-20047: Data Dictionary Documentation (#4271)
50d8da9
beeyayjay pushed a commit that referenced this pull request Jan 6, 2025
@rovcase
WCMS-20047: Data Dictionary Documentation (#4271)
e2c93fb
beeyayjay pushed a commit that referenced this pull request Jan 6, 2025
@rovcase
WCMS-20047: Data Dictionary Documentation (#4271)
a9ccde9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmundra dmundra dmundra requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rovcase @dmundra