Set 404 exception if dataset ID isn't found. #4379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeyayjay
force-pushed
the
missing-dataset-404
branch
from
24caef8 to
d57c3e3
Compare
beeyayjay
force-pushed
the
missing-dataset-404
branch
from
d57c3e3 to
21d87a2
Compare
dafeder
requested changes
Jan 16, 2025
| use Drupal\Tests\BrowserTestBase; | ||
| use GuzzleHttp\RequestOptions; | ||
|
|
||
| class DatasetControllerTest extends BrowserTestBase { |
There was a problem hiding this comment.
This isn't actually testing the dkan_js_frontend controller, because the module is not enabled for this test. It's getting a 404 because it's not a valid URL either way, but it's just coming from normal Drupal routing and node controller. That's why it's getting flagged for test coverage.
There was a problem hiding this comment.
Thanks @dafeder. That hadn't occurred to me. I'll fix.
…s_frontend is enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [issue#]
6711
QA Steps