refactor(components): move Grid to leverage compositional patterns #2074
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes Grid allow children and leverage Grid.Cell to handle the CSS.
Motivations
Currently, Grid does not allow application developers to abstract away its children into re-usable components. This was due to mapping over the Children directly and proxying their props to an InternalGridCell component that expected the props of the immediate children to be Grid.Cell properties.
The original intent was to guide developers in leveraging Grid.Cell, as the first child causes issues for any developers who wish to create intermediary components for re-use. The solution was to just remove the intermediary guards in favour of rendering the children and allowing CSS to handle the logic of properly handling layout concerns.
Changes
Refactors Grid to allow any children and expose Grid.Cell directly.
Testing
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.